Skip to content

Custom icon styling tweaks #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2025
Merged

Custom icon styling tweaks #1877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1cf74c1
Set max-height/max-width on custom icon images
cpsievert Feb 28, 2025
65d59d2
Add .border-0 class that can be put on custom icons to opt-out of ico…
cpsievert Feb 28, 2025
2a05988
Apply suggestions from code review
cpsievert Feb 28, 2025
287fee0
yarn build
cpsievert Feb 28, 2025
38437c5
Add max-height/max-width to all icons
cpsievert Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions js/chat/chat.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ shiny-chat-message {
// images and avatars are full-bleed
height: 100%;
width: 100%;
max-width: 100%;
max-height: 100%;
margin: 0 !important;
object-fit: contain;
}
Expand All @@ -95,6 +97,13 @@ shiny-chat-message {
max-height: 66%;
max-width: 66%;
}

// Provide .border-0 as a way to opt-out of border container
&:has(> .border-0) {
border: none;
border-radius: unset;
overflow: unset;
}
}

/* Vertically center the 2nd column (message content) */
Expand Down
2 changes: 1 addition & 1 deletion shiny/www/py-shiny/chat/chat.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shiny/www/py-shiny/chat/chat.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading