-
Notifications
You must be signed in to change notification settings - Fork 114
feat: chat.update_user_input()
can submit
and focus
the input
#1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gadenbuie
merged 19 commits into
chat-suggestions-submit
from
chat-suggestions-submit-focus
Feb 13, 2025
Merged
feat: chat.update_user_input()
can submit
and focus
the input
#1851
gadenbuie
merged 19 commits into
chat-suggestions-submit
from
chat-suggestions-submit-focus
Feb 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
commented
Feb 12, 2025
cb92608
to
a057c53
Compare
gadenbuie
commented
Feb 12, 2025
gadenbuie
commented
Feb 13, 2025
tests/playwright/shiny/components/chat/update_user_input/test_chat_update_user_input.py
Outdated
Show resolved
Hide resolved
cpsievert
reviewed
Feb 13, 2025
cpsievert
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stacks on #1847
Adds
submit
andfocus
options toChatInput.setInputValue()
which are then also exposed in Python viachat.update_user_input()
.TODO: