Skip to content

chore: Fix langchain_core test that used a new Sequence type #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2024
Merged

chore: Fix langchain_core test that used a new Sequence type #1697

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64abd06
touch file
schloerke Sep 20, 2024
ffdea07
Use langchain's Sequence object to avoid incorrect comparisons betwee…
schloerke Sep 20, 2024
8c320ba
Discard changes to pyproject.toml
schloerke Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/pytest/test_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import sys
from datetime import datetime
from typing import Sequence, Union, cast, get_args, get_origin
from typing import Union, cast, get_args, get_origin

import pytest

Expand Down Expand Up @@ -390,6 +390,9 @@ def test_as_google_message():

def test_as_langchain_message():
from langchain_core.language_models.base import LanguageModelInput
from langchain_core.language_models.base import (
Sequence as LangchainSequence, # pyright: ignore[reportPrivateImportUsage]
)
from langchain_core.language_models.chat_models import BaseChatModel
from langchain_core.messages import (
AIMessage,
Expand All @@ -404,7 +407,12 @@ def test_as_langchain_message():
assert BaseChatModel.invoke.__annotations__["input"] == "LanguageModelInput"
assert BaseChatModel.stream.__annotations__["input"] == "LanguageModelInput"

assert is_type_in_union(Sequence[MessageLikeRepresentation], LanguageModelInput)
assert is_type_in_union(
# Use `LangchainSequence` instead of `Sequence` to avoid incorrect comparison
# between `typing.Sequence` and `collections.abc.Sequence`
LangchainSequence[MessageLikeRepresentation],
LanguageModelInput,
)
assert is_type_in_union(BaseMessage, MessageLikeRepresentation)

assert issubclass(AIMessage, BaseMessage)
Expand Down
Loading