Skip to content

test(browsers): Unskip webkit tests #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2024
Merged

test(browsers): Unskip webkit tests #1431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0e26b4
Remove skip for webkit browser tests
karangattu May 17, 2024
e756b3d
remove unnecessary import
karangattu May 17, 2024
f1d9e96
Merge branch 'main' into unskip-webkit-tests
karangattu May 23, 2024
a811908
Merge branch 'main' into unskip-webkit-tests
schloerke May 28, 2024
11473f1
Merge branch 'main' into playwright-unskip-webkit-tests
karangattu May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/playwright/shiny/bugs/0696-resolve-id/test_0696_resolve_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ def expect_default_outputs(page: Page, module_id: str):

# Sidebars do not seem to work on webkit. Skipping test on webkit
@pytest.mark.flaky(reruns=reruns, reruns_delay=reruns_delay)
@pytest.mark.skip_browser("webkit")
def test_module_support(page: Page, local_app: ShinyAppProc) -> None:
page.set_viewport_size({"width": 3000, "height": 6000})
page.goto(local_app.url)
Expand Down
2 changes: 0 additions & 2 deletions tests/playwright/shiny/components/nav/test_nav.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

from dataclasses import dataclass

import pytest
from conftest import ShinyAppProc
from controls import (
LayoutNavSetBar,
Expand All @@ -17,7 +16,6 @@
from playwright.sync_api import Page


@pytest.mark.skip_browser("webkit")
def test_nav(page: Page, local_app: ShinyAppProc) -> None:
page.goto(local_app.url)

Expand Down