Skip to content

bug(output transformer): fix transformer auto-registration #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2024
Merged

bug(output transformer): fix transformer auto-registration #1394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8c75c
Fix output transformer auto registration
karangattu May 17, 2024
ff96fcd
Unskip broken tests
karangattu May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shiny/render/transformer/_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,8 @@ def __init__(
self._default_ui_args: tuple[object, ...] = tuple()
self._default_ui_kwargs: dict[str, object] = dict()

# Allow for App authors to not require `@output`
self._auto_register()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

# Register the value function with the parent Renderer class
self(value_fn)

def _meta(self) -> TransformerMetadata:
"""
Expand Down
2 changes: 0 additions & 2 deletions tests/playwright/shiny/deprecated/output_transformer/test_output_transformer_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import pytest
from conftest import ShinyAppProc
from controls import OutputTextVerbatim
from playwright.sync_api import Page


@pytest.mark.skip(reason="Flaky test. Fix before renabling")
def test_output_image_kitchen(page: Page, local_app: ShinyAppProc) -> None:
page.goto(local_app.url)

Expand Down
2 changes: 0 additions & 2 deletions tests/playwright/shiny/server/output_transformer/test_output_transformer_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import pytest
from conftest import ShinyAppProc
from controls import OutputTextVerbatim
from playwright.sync_api import Page


@pytest.mark.skip(reason="Flaky test. please fix before enabling")
def test_output_transformer(page: Page, local_app: ShinyAppProc) -> None:
page.goto(local_app.url)

Expand Down