Skip to content

Stop sending recalculated message immediately after persistent progress message #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024
Merged

Stop sending recalculated message immediately after persistent progress message #1356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ed45ec
Close #1355. Stop sending recalculated message immediately after pers…
cpsievert May 6, 2024
aa894f6
Add clarifying comment
cpsievert May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions shiny/session/_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1414,9 +1414,10 @@ async def output_obs():
session._send_progress(
"binding", {"id": output_name, "persistent": True}
)
# It's important to exit early here _without_ a recalculated message
return
except SilentCancelOutputException:
return
pass
except SilentException:
session._outbound_message_queues.set_value(output_name, None)
except Exception as e:
Expand All @@ -1436,16 +1437,15 @@ async def output_obs():
"type": None,
}
session._outbound_message_queues.set_error(output_name, err_message)
return
finally:
await session._send_message(
{
"recalculating": {
"name": output_name,
"status": "recalculated",
}

await session._send_message(
{
"recalculating": {
"name": output_name,
"status": "recalculated",
}
)
}
)

output_obs.on_invalidate(
lambda: require_real_session()._send_progress(
Expand Down