Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions shiny/ui/_download_button.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,19 @@ def download_button(
return tags.a(
icon,
label,
{"class": "btn btn-default shiny-download-link", "style": css(width=width)},
{
"class": "btn btn-default shiny-download-link disabled",
"style": css(width=width),
},
id=resolve_id(id),
# This is a fake link that just results in a 404. It will be replaced by a
# working link after the server side logic runs, so this link will only be
# visited in cases where the user clicks the button too fast, or if the server
# never defines a handler for this download button.
href="session/0/download/missing_download",
href="",
target="_blank",
# We can't use `download` in pyodide mode, because the browser chooses not to
# route the download through the service worker in that case. (Observed by
# jcheng on 1/7/2022, using Chrome Version 96.0.4664.110.)
download=None if is_pyodide else True,
aria_disabled="true",
tabindex="-1",
**kwargs,
)

Expand Down Expand Up @@ -103,10 +104,12 @@ def download_link(
return tags.a(
icon,
label,
{"class": "shiny-download-link", "style": css(width=width)},
{"class": "shiny-download-link disabled", "style": css(width=width)},
id=resolve_id(id),
href="session/0/download/missing_download",
href="",
target="_blank",
download=None if is_pyodide else True,
aria_disabled="true",
tabindex="-1",
**kwargs,
)
2 changes: 1 addition & 1 deletion shiny/www/shared/_version.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"note!": "This file is auto-generated by scripts/htmlDependencies.R",
"package": "shiny",
"version": "Github (rstudio/shiny@950c63049b37cb3156bf134fa4ff13ad3cedee48)"
"version": "Github (rstudio/shiny@2872c87e3239ffd4f8ab8560974a98600dcd755d)"
}
4 changes: 2 additions & 2 deletions shiny/www/shared/bootstrap/_version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"note!": "This file is auto-generated by scripts/htmlDependencies.R",
"shiny_version": "Github (rstudio/shiny@950c63049b37cb3156bf134fa4ff13ad3cedee48)",
"bslib_version": "Github (rstudio/bslib@2c87d0c8753d003fef66858235ead8c9206aefa9)",
"shiny_version": "Github (rstudio/shiny@2872c87e3239ffd4f8ab8560974a98600dcd755d)",
"bslib_version": "Github (rstudio/bslib@3dd55fd7249d30ecddac8f98ba8dc70aee0b3459)",
"htmltools_version": "Github (rstudio/htmltools@038ef7be3b02a9248f122b745ad7830cc429d437)",
"bootstrap_version": "5.3.1"
}
2 changes: 1 addition & 1 deletion shiny/www/shared/bslib/_version.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"note!": "This file is auto-generated by scripts/htmlDependencies.R",
"package": "bslib",
"version": "Github (rstudio/bslib@2c87d0c8753d003fef66858235ead8c9206aefa9)"
"version": "Github (rstudio/bslib@3dd55fd7249d30ecddac8f98ba8dc70aee0b3459)"
}
4 changes: 2 additions & 2 deletions shiny/www/shared/bslib/components/components.min.js

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions shiny/www/shared/bslib/components/components.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion shiny/www/shared/bslib/components/web-components.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shiny/www/shared/bslib/components/web-components.min.js.map

Large diffs are not rendered by default.

Loading