Skip to content

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Mar 6, 2024

  • Also mark resolve_id test as flaky to make sure it's not a random error.
  • Always save trace/video when debugging playwright.

@schloerke schloerke added this to the v0.8.1 milestone Mar 6, 2024
@schloerke schloerke self-assigned this Mar 6, 2024
@schloerke schloerke changed the title test: Always turn on video and tracing when using make playwright-debug test: Always save trace/video when debugging playwright. Do not attempt deploys job unless conditions are valid Mar 6, 2024
@schloerke schloerke requested a review from karangattu March 6, 2024 18:07
schloerke and others added 2 commits March 6, 2024 13:37
@schloerke schloerke changed the title test: Always save trace/video when debugging playwright. Do not attempt deploys job unless conditions are valid test: Speed up tests by using single page. Do not attempt deploys job unless conditions are valid Mar 6, 2024
@schloerke schloerke merged commit 11b83c3 into main Mar 6, 2024
@schloerke schloerke deleted the debug-flaky-test branch March 6, 2024 19:15
schloerke added a commit that referenced this pull request Mar 6, 2024
* main: (35 commits)
  test: Speed up tests by using single page. Do not attempt deploys job unless conditions are valid (#1197)
  ci: Run `playwright-examples` on Python 3.12 as well (#1195)
  Shiny preset style updates and nudges (#1176)
  tests: Upload trace on failed tests (#1196)
  Fix datetime input in airmass example app (#1194)
  Better docs for `render.download` (#1193)
  Render `shiny.min.css` using `bs_theme()` (#1191)
  Fix `express.ui.update_date` and`express.ui.update_text` links (#1192)
  Use `cast()` for asgiref types only when type checking (#1190)
  Remove uvicorn and click dependencies in Emscripten (#1187)
  Remove asgiref run-time dependency (#1183)
  Install dev-shinylive via Makefile (#1184)
  Put all "Other Changes" items into one section
  Use consistent formatting for items in changelog
  Don't run playwright-deploys tests on release
  tests(resolve-id): Update window size to ensure tooltip is visible (#1179)
  Setup dev version 0.8.0.9000 (#1181)
  Bump version to 0.8.0
  Revert API changes made in `Selected rows method` #1121 (#1174)
  Make autoreload work on codespaces (#1167)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants