Skip to content

For page_sidebar and page_navbar, consider changing default for fillable to False #938

@wch

Description

@wch

For Express mode we had set the default page type to page_fillable(), but changed it back to page_fixed() for reasons explained in #886.

In Express mode, when a sidebar is added, it uses page_sidebar(), which defaults to fillable=True and then runs into the same problem. That means that from the user's perspective, simply adding a sidebar makes a big change in how the main content of the page is laid out, and can lead to surprising errors. For example:

image

Then the user needs to know to use ui.page_opts(fillable=False) to fix it.

Especially in cases where there is a lot of content on the page, I think it would be very surprising for a user that simply adding a sidebar would result in this change; and then in order to understand the fix, they would need to understand the fillable concept, and that the sidebar changes the default behavior of it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions