Skip to content

fix(python): Enable manual commits for write_database with the ADBC engine #24559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(python): Enable manual commits for write_database with the ADBC engine #24559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1696831
Update _utils.py
mullimanko Sep 21, 2025
252592c
Update frame.py
mullimanko Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion py-polars/polars/dataframe/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4402,7 +4402,6 @@ def unpack_table_name(name: str) -> tuple[str | None, str | None, str]:
mode=mode,
**(engine_options or {}),
)
conn.commit()
return n_rows

elif engine == "sqlalchemy":
Expand Down
2 changes: 1 addition & 1 deletion py-polars/polars/io/database/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,4 @@ def _open_adbc_connection(connection_uri: str) -> Any:
if driver_name in ("duckdb", "snowflake", "sqlite"):
connection_uri = re.sub(f"^{driver_name}:/{{,3}}", "", connection_uri)

return adbc_driver.connect(connection_uri)
return adbc_driver.connect(connection_uri, autocommit=True)
Loading