Skip to content

Conversation

kdn36
Copy link
Collaborator

@kdn36 kdn36 commented Sep 19, 2025

fixes #24504
fixed undocumented issues (e.g. mismatching groups similar to #24500 but for BinaryExpr)

This PR is a refactor similar to #24520 but for BinaryExpr instead of ApplyExpr. It includes regression tests for all combinations of aggstates, with and without partial sort, as well as raising an error on groups mismatch.

Not to be merged until:
(i) The PR for the reference case of ApplyExpr has been approved for merged; and this PR is rebased on it.
(ii) TODO: scope decision on how to handle dynamic_group_by, preferably by evolving the concept of rolling to overlapping.
(iii) TODO: consolidate dispatch logic.
(iv) Performance regression check.

@kdn36 kdn36 marked this pull request as draft September 19, 2025 12:22
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 19, 2025
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 98.61111% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.75%. Comparing base (f0fc158) to head (9c1aa3a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/expressions/binary.rs 98.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24548      +/-   ##
==========================================
- Coverage   81.81%   81.75%   -0.07%     
==========================================
  Files        1683     1684       +1     
  Lines      229051   229509     +458     
  Branches     2946     2952       +6     
==========================================
+ Hits       187406   187641     +235     
- Misses      40906    41125     +219     
- Partials      739      743       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ritchie46 ritchie46 force-pushed the main branch 3 times, most recently from ddf5907 to d0914d4 Compare September 27, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort in add expr in group_by context propagates to other column
1 participant