fix: Refactor BinaryExpr
in group_by
with partial sort
#24548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24504
fixed undocumented issues (e.g. mismatching groups similar to #24500 but for BinaryExpr)
This PR is a refactor similar to #24520 but for
BinaryExpr
instead ofApplyExpr
. It includes regression tests for all combinations of aggstates, with and without partial sort, as well as raising an error on groups mismatch.Not to be merged until:
(i) The PR for the reference case of
ApplyExpr
has been approved for merged; and this PR is rebased on it.(ii) TODO: scope decision on how to handle
dynamic_group_by
, preferably by evolving the concept ofrolling
tooverlapping
.(iii) TODO: consolidate dispatch logic.
(iv) Performance regression check.