feat: Add ignore_nulls to first/last
#24455
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
mcrumiller
force-pushed
the
first-non-null-expr
branch
2 times, most recently
from
3b16e47 to
4b7831c
Compare
mcrumiller
commented
Sep 12, 2025
Comment on lines
65
to
81
| let indices = if ignore_nulls && s.null_count() != 0 { | ||
| let null_s = s.is_null(); | ||
| let null_values = null_s.downcast_as_array(); | ||
| groups | ||
| .iter() | ||
| .map(|(_, idx)| { | ||
| let mut this_idx = None; | ||
| for &ii in idx.iter() { | ||
| // SAFETY: null_values has no no values | ||
| if !null_values.value_unchecked(ii as usize) { | ||
| this_idx = Some(ii); | ||
| break; | ||
| } | ||
| } | ||
| this_idx | ||
| }) | ||
| .collect_ca(PlSmallStr::EMPTY) |
There was a problem hiding this comment.
@coastalwhite is this more what you had in mind?
mcrumiller
force-pushed
the
first-non-null-expr
branch
from
7b7941a to
7758e09
Compare
mcrumiller
force-pushed
the
first-non-null-expr
branch
from
7758e09 to
0d76036
Compare
ritchie46
force-pushed
the
main
branch
3 times, most recently
from
ddf5907 to
d0914d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #22547.
This supercedes #24441 and only implements
ignore_nullsfor basic dtype expressions andgroup_by, and does not include list/array dtypes. The next PR will tackle list/array.This PR touches a lot of files because there are many existing calls to first that had to be updated with the new parameter. An alternative that would leave more of the codebase untouched would be to add new expressions first_non_null and last_non_null. Let me know if you think this would be preferable.
Drafting this until I can figure out the streaming part of first/last.