Set axis linecolor to black by default when converting from matplotlib #5311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvwilson
added
P1
robertoffmoura
force-pushed
the
rm/default-axis-linecolor-black
branch
from
e65619c to
0335226
Compare
|
@robertoffmoura Thanks for the contribution! I'm happy to merge this but just to make sure I have the full context, can you explain why this is the correct behavior? Are the axes lines black by default in matplotlib? |
|
Hi @emilykl, |
robertoffmoura
force-pushed
the
rm/default-axis-linecolor-black
branch
from
0335226 to
9e6fea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plotly.graph_objects, my modifications concern the code generator and not the generated files.