Skip to content

Boxpoints no range #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2016
Merged

Boxpoints no range #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb64307
fallbacks for jitter algo with no IQR and lots of duplicate points
alexcjohnson Sep 7, 2016
c8c5a03
boxplots: handle jitter in edge case of no data range at all
alexcjohnson Sep 8, 2016
ae7bcab
box plot jitter edge cases test image
alexcjohnson Sep 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 29 additions & 16 deletions src/traces/box/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ module.exports = function plot(gd, plotinfo, cdbox) {
.data(function(d) {
var pts = (trace.boxpoints === 'all') ? d.val :
d.val.filter(function(v) { return (v < d.lf || v > d.uf); }),
spreadLimit = (d.q3 - d.q1) * JITTERSPREAD,
// normally use IQR, but if this is 0 or too small, use max-min
typicalSpread = Math.max((d.max - d.min) / 10, d.q3 - d.q1),
minSpread = typicalSpread * 1e-9,
spreadLimit = typicalSpread * JITTERSPREAD,
jitterFactors = [],
maxJitterFactor = 0,
i,
Expand All @@ -144,22 +147,32 @@ module.exports = function plot(gd, plotinfo, cdbox) {

// dynamic jitter
if(trace.jitter) {
for(i = 0; i < pts.length; i++) {
i0 = Math.max(0, i - JITTERCOUNT);
pmin = pts[i0];
i1 = Math.min(pts.length - 1, i + JITTERCOUNT);
pmax = pts[i1];

if(trace.boxpoints !== 'all') {
if(pts[i] < d.lf) pmax = Math.min(pmax, d.lf);
else pmin = Math.max(pmin, d.uf);
if(typicalSpread === 0) {
// edge case of no spread at all: fall back to max jitter
maxJitterFactor = 1;
jitterFactors = new Array(pts.length);
for(i = 0; i < pts.length; i++) {
jitterFactors[i] = 1;
}
}
else {
for(i = 0; i < pts.length; i++) {
i0 = Math.max(0, i - JITTERCOUNT);
pmin = pts[i0];
i1 = Math.min(pts.length - 1, i + JITTERCOUNT);
pmax = pts[i1];

if(trace.boxpoints !== 'all') {
if(pts[i] < d.lf) pmax = Math.min(pmax, d.lf);
else pmin = Math.max(pmin, d.uf);
}

jitterFactor = Math.sqrt(spreadLimit * (i1 - i0) / (pmax - pmin + minSpread)) || 0;
jitterFactor = Lib.constrain(Math.abs(jitterFactor), 0, 1);

jitterFactors.push(jitterFactor);
maxJitterFactor = Math.max(jitterFactor, maxJitterFactor);
}

jitterFactor = Math.sqrt(spreadLimit * (i1 - i0) / (pmax - pmin)) || 0;
jitterFactor = Lib.constrain(Math.abs(jitterFactor), 0, 1);

jitterFactors.push(jitterFactor);
maxJitterFactor = Math.max(jitterFactor, maxJitterFactor);
}
newJitter = trace.jitter * 2 / maxJitterFactor;
}
Expand Down
Binary file added test/image/baselines/box_plot_jitter_edge_cases.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
32 changes: 32 additions & 0 deletions test/image/mocks/box_plot_jitter_edge_cases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"data": [
{
"y": [0,0,2.4,0,0,2,0,0,0,0,0,0,62,0,0,0,13,0,0,0,0,38,0,0,0,0,0,0,0,0],
"type": "box",
"boxpoints": "all",
"jitter": 0,
"name": "No whiskers, no jitter"
},
{
"y": [0,0,2.4,0,0,2,0,0,0,0,0,0,62,0,0,0,13,0,0,0,0,38,0,0,0,0,0,0,0,0],
"type": "box",
"boxpoints": "all",
"jitter": 0.5,
"name": "No whiskers, jitter 0.5"
},
{
"y": [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],
"type": "box",
"boxpoints": "all",
"jitter": 0,
"name": "No range, no jitter"
},
{
"y": [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],
"type": "box",
"boxpoints": "all",
"jitter": 0.5,
"name": "No range, jitter 0.5"
}
]
}