fix: Fix USA subunits, clean up land, coastlines topojson layers #7555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilykl
reviewed
Sep 11, 2025
| "noConsole": { "level": "off", "options": { "allow": ["log"] } } | ||
| } | ||
| }, | ||
| "includes": [ |
There was a problem hiding this comment.
@camdecoster What is the effect of this config change?
There was a problem hiding this comment.
You can override the global includes using this one. It included all the same stuff as the global one, so I removed it as redundant.
emilykl
reviewed
Sep 11, 2025
|
|
||
| async function createSubunitsLayer({ name, resolution, source }) { | ||
| const filter = ['AUS', 'BRA', 'CAN', 'USA'].map((id) => `adm0_a3 === "${id}"`).join(' || '); | ||
| // Only include USA for 'usa' scope since the UN and NE borders don't match exactly and slivers of Canada creep in |
There was a problem hiding this comment.
slivers of Canada creep in
😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Omit Canadian provinces from USA subunits and snap polygons for land, coastlines topojson layers.
Closes #7528.
Changes
Screenshots
Testing
cd topojson && npm run buildTODO