Skip to content

Fix: Fix installing dependencies in node v22 #7381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 3, 2025
Merged

Fix: Fix installing dependencies in node v22 #7381

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e91848e
Fix installing dependencies in node v22
chaigh-uk Feb 27, 2025
436b1be
Add draft log
chaigh-uk Feb 27, 2025
d042e92
Fix installing dependencies in node v22
chaigh-uk Feb 27, 2025
b730cb5
Add draft log
chaigh-uk Feb 27, 2025
46e0277
Add publish-dist-node-v22 test
chaigh-uk Apr 2, 2025
4aff910
Merge branch 'fix-deps-node-22' of github.com:chaigh-uk/plotly.js int…
chaigh-uk Apr 2, 2025
2bbaec5
Update draftlogs/7381_fix.md
archmoj Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ jobs:
name: Run syntax tests on source files
command: .circleci/test.sh source-syntax

publish-dist:
publish-dist: &publish-dist
docker:
- image: cimg/node:18.20.4
working_directory: ~/plotly.js
Expand Down Expand Up @@ -465,6 +465,11 @@ jobs:
name: Test plot-schema.json diff - If failed, after (npm start) you could run (npm run schema && git add test/plot-schema.json && git commit -m "update plot-schema diff")
command: diff --unified --color dist/plot-schema.json test/plot-schema.json

publish-dist-node-v22:
<<: *publish-dist
docker:
- image: cimg/node:22.14.0

test-stackgl-bundle:
docker:
- image: cimg/node:18.20.4
Expand Down Expand Up @@ -552,4 +557,6 @@ workflows:

- publish-dist

- publish-dist-node-v22

- test-stackgl-bundle
1 change: 1 addition & 0 deletions draftlogs/7381_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix installing dependencies in node v22 [[#7381](https://github.com/plotly/plotly.js/pull/7381)]
Loading