A few fixes in convertToTspans #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check for white list of anchor attributes - check for correct 'xlink:show' value
- fixes #642 - strip only the leading '=' - replace & with '&' to make DOMParser happy - wrap resulting href in ""
| assertAnchorLink(node, 'mailto:[email protected]'); | ||
| }); | ||
|
|
||
| it('wrap XSS attacks in href', function() { |
There was a problem hiding this comment.
The previous commit d58d3be also appears to have fix the XSS issue discovered in https://github.com/plotly/streambed/issues/7056 - would you mind reviewing this?
There was a problem hiding this comment.
Looks good to me! Let me know when it's on prod and I'll play with it a bit to be extra sure.
rreusser
added a commit
that referenced
this pull request
Jul 27, 2016
rreusser
added a commit
that referenced
this pull request
Jul 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #642
See d58d3be and f6a5c67