Skip to content

Speed up Lib.extendDeep (_extend) for arrays that have no object, array elements #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2016
Merged

Speed up Lib.extendDeep (_extend) for arrays that have no object, array elements #732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/lib/extend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,20 @@
var isPlainObject = require('./is_plain_object.js');
var isArray = Array.isArray;

function primitivesLoopSplice(source, target) {
var i, value;
for(i = 0; i < source.length; i++) {
value = source[i];
if(value !== null && typeof(value) === 'object') {
return false;
}
if(value !== void(0)) {
target[i] = value;
}
}
return true;
}

exports.extendFlat = function() {
return _extend(arguments, false, false);
};
Expand Down Expand Up @@ -45,7 +59,18 @@ function _extend(inputs, isDeep, keepAllKeys) {
var target = inputs[0],
length = inputs.length;

var input, key, src, copy, copyIsArray, clone;
var input, key, src, copy, copyIsArray, clone, allPrimitives;

if(length === 2 && isArray(target) && isArray(inputs[1]) && target.length === 0) {

allPrimitives = primitivesLoopSplice(inputs[1], target);

if(allPrimitives) {
return target;
} else {
target.splice(0, target.length); // reset target and continue to next block
}
}

for(var i = 1; i < length; i++) {
input = inputs[i];
Expand Down