Make dragmode 'lasso' & 'select' work with fixedrange axes #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var subplotIds; | ||
| manageModeBar(gd); | ||
|
|
||
| Plotly.Fx.supplyLayoutDefaults(gd.layout, fullLayout, gd._fullData); |
There was a problem hiding this comment.
?
Why is this in the domodebar block?
There was a problem hiding this comment.
domodebar (i.e. when only the dragmode or the hovermode changes) by-passes a bunch of things. So instead of running the whole Plots.supplyDefaults it only need to call the Fx defaults step and re-initialise the drag boxes.
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #657
Previously, we made the main dragbox inactive whenever both xaxis and yaxis were
fixedrange: trueregardless of thedragmode. This is of course correct for dragmode'pan'and'lasso'but wrong for'lasso'and'select'. This PR fixes the latter two cases. In addition, this PR cleans up some modebar -> relayout code paths.