Skip to content

Make invalid mapbox layers work with relayout #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2016
Merged

Make invalid mapbox layers work with relayout #693

merged 2 commits into from
Jun 28, 2016

Conversation

etpinard
Copy link
Contributor

Previously,

// create an empty layer
relayout(gd, {'mapbox.layers[0]': {}});

// add geojson to that layer
relayout(gd, {'mapbox.layers[0].source': geojson});

resulted in errors. This PR fixes it.

etpinard added 2 commits June 27, 2016 13:51
@etpinard
mapbox: handle non-visible to visible in update method
6e748ef 
- so that a layer object created with an invalid source
  can be relayouted with a valid one.
@etpinard
fixup has-no-webgl-support logs
c839b4c
@etpinard etpinard added bug something broken status: reviewable labels Jun 27, 2016
@mdtusz
Copy link
Contributor

mdtusz commented Jun 28, 2016

Looks good to me 💃

@etpinard etpinard merged commit d052f82 into master Jun 28, 2016
@etpinard etpinard deleted the mapbox-layer-relayout branch June 28, 2016 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etpinard @mdtusz