Skip to content

add delta.prefix and delta.suffix in Indicator trace #6225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add delta.prefix and delta.suffix in Indicator trace #6225

wants to merge 1 commit into from

Conversation

paulovieira
Copy link
Contributor

  • in drawDelta added deltaSuffix/deltaPrefix, following what was done in the respective suffix/prefix for number (implemented in drawBignumber)
  • in drawBignumber renamed fmt to bignumberFmt for clarity

Closes #4824

ezgif com-gif-maker

@archmoj archmoj added feature something new status: reviewable community community contribution labels Jun 14, 2022
@archmoj
Copy link
Contributor

archmoj commented Jun 14, 2022

Thanks very much for the PR.
Looks great!

Two minor comments for now:

  1. Please run npm run schema then commit the changes.
  2. Please create draftlog/6225_add file as described here.

@paulovieira paulovieira mentioned this pull request Jun 28, 2022
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

community community contribution feature something new

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prefix / Suffix for Delta in Indicator

2 participants

@paulovieira @archmoj