Skip to content

tick text description typo #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2016
Merged

tick text description typo #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plots/cartesian/layout_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ module.exports = {
description: [
'Sets the text displayed at the ticks position via `tickvals`.',
'Only has an effect if `tickmode` is set to *array*.',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually while editing this, could I rm 'Only has an effect if tickmode is set to array.' cause that's actually not true anymore right @etpinard // @mdtusz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends what we mean by set.

Does set mean:

  1. that tickmode has to be set by the user to 'array', or
  2. that tickmode is either set by the user to 'array' or inferred to be 'array' by tickvals.

I think item 1. is probably what most people would understand by set. But how should we describe situation similar to item 2. ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh yes you're totally right, I wasn't thinking about opt 2.
We should probably leave as is for now then. (but just change the typo in this commit)

'Used with `ticktext`.'
'Used with `tickvals`.'
].join(' ')
},
ticks: {
Expand Down