Skip to content

Use ids from axes instead of [object Object] in hover data key #5852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2021
Merged

Use ids from axes instead of [object Object] in hover data key #5852

merged 2 commits into from
Jul 29, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 24, 2021

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jul 24, 2021
@archmoj archmoj requested a review from alexcjohnson July 24, 2021 17:58
@archmoj
Copy link
Contributor Author

archmoj commented Jul 29, 2021

@alexcjohnson Let's also try to get this into v2.3.1.

alexcjohnson
alexcjohnson approved these changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 😆

@archmoj archmoj merged commit b3bff15 into master Jul 29, 2021
@archmoj archmoj deleted the fix-hover-data-key branch July 29, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees

No one assigned

Labels

bug something broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@archmoj @alexcjohnson