Fix overlap of legend border and scroll box #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved clip-path from legend to scrollbox. * Shifted bg half a border-width to ensure it doesn't overlap with the scroll box. * Updated the method to compute the legend height used in `legend_scroll_test.js` to account for the legend clip-path being one border-witdh smaller. * Updated the baseline images for `17.json, `20.json`, `legend_scroll.json`, `legend_style` and `text_export`. The differences were due to the overlap and the border shift.
|
Fixes the overlap described here. This PR is ready for review. |
|
Looks pretty good to me. Thanks for doing this! 💃 |
n-riesco
deleted the
fix-legend-scrollbox-and-border-overlap-without-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scroll box.
legend_scroll_test.jsto account for the legend clip-path being oneborder-witdh smaller.
17.json,20.json,legend_scroll.json,legend_styleandtext_export`. Thedifferences were due to the overlap and the border shift.