Skip to content

Conversation

Hypercubed
Copy link
Contributor

Two issues were preventing npm run test-jasmine on windows:

  1. karma-browserify had a bug (See fix(preprocessor): use full path to temp dir for browserify-bundle pr… nikku/karma-browserify#154, fixed by bumping to karma-browserify 4.4.1).
  2. On windows (or cygwin) paths generated by the requireTransform browserify transform contain platform-specific file separators (fixed by converting file separators).

@Hypercubed
Copy link
Contributor Author

See #29

@etpinard
Copy link
Contributor

@Hypercubed Beautiful. Thanks so much for doing this.

FYI: we're fighting some test randomness issues on CircleCI, rebuilding your test run was enough to get the tests to pass.

etpinard added a commit that referenced this pull request Nov 30, 2015
@etpinard etpinard merged commit e210f41 into plotly:master Nov 30, 2015
@etpinard etpinard mentioned this pull request Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants