Fix UMD in plotly.js dist files #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- appending `Plotly.version` is the bundle break UMD more info: #14
- task bundle.js uses the verisonify transform to insert to package.json version in exports.version - watch builds don't use the versionify transform because it breaks source maps webpro/versionify#11 - the exports.version placeholder is set to 'see pacakge.json'
src/assets/geo_assets.js
Outdated
There was a problem hiding this comment.
the append_version transform pulls in the package.json... would this work here?
exports.version = require('../../package.json').version
…es:" This reverts commit afaeeaf.
- to show package version onto exported object in a low-cost, seemless way.
|
sure lets give it a shot! 💃 |
etpinard
added a commit
that referenced
this pull request
Nov 20, 2015
Fix UMD in plotly.js dist files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
Use
to add package version to the exported object without interfering with UMD.