Skip to content

Annotationclick event #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2017
Merged

Annotationclick event #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de3801d
report mouse event in clickannotation
alexcjohnson May 8, 2017
0a6ca10
test clickannotation mouse event
alexcjohnson May 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/annotations/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ function drawOne(gd, index) {
gd.emit('plotly_clickannotation', {
index: index,
annotation: optionsIn,
fullAnnotation: options
fullAnnotation: options,
event: d3.event
});
});

Expand Down
6 changes: 5 additions & 1 deletion test/jasmine/tests/annotations_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,11 @@ describe('annotation effects', function() {
], {}) // turn off the default editable: true
.then(function() {
clickData = [];
gd.on('plotly_clickannotation', function(evt) { clickData.push(evt); });
gd.on('plotly_clickannotation', function(evt) {
expect(evt.event).toEqual(jasmine.objectContaining({type: 'click'}));
delete evt.event;
clickData.push(evt);
});

gdBB = gd.getBoundingClientRect();
pos0Head = [gdBB.left + 200, gdBB.top + 200];
Expand Down