Make surface handle zmin/zmax [fixes #86] #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- due to rounding differences in the zmin and zmax computations and the gl-surface3d bounds computations.
There was a problem hiding this comment.
the only interesting part of this PR on the plotly.js side.
|
looks good to me! 💃 |
etpinard
added a commit
that referenced
this pull request
Jan 5, 2016
Make surface handle zmin/zmax [fixes #86]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass scaled
zminandzmax(which are computed in the colorscale calc step) to the new gl-surface3dcolorBoundsparameter.Requires:
zminandzmaxcomputations and the gl-surface3d bounds computations.