Don't unscale bar layer points on drag #1370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
commented
Feb 10, 2017
| assertScale(this, 1, 1); | ||
| }); | ||
|
|
||
| mouseEvent('mouseup', pos[0] + 50, pos[1]); |
There was a problem hiding this comment.
Fun fact. This test case doesn't need a mouseup event to test what is desired. But, we need to trigger one to not affect other tests downstream (namely in config_test.js).
etpinard
commented
Feb 10, 2017
| // scale to individual points to counteract the scale of the trace | ||
| // as a whole: | ||
| .selectAll('.points').selectAll('.point') | ||
| .select('.scatterlayer').selectAll('.points').selectAll('.point') |
There was a problem hiding this comment.
@rreusser would you mind reviewing the line?
There was a problem hiding this comment.
That makes sense to me. It's certainly better, though I can't say from direct knowledge that nothing puts stray items in the scatterlayer .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1251
as mentioned in #1251 (comment) the fix was pretty easy, writing a test for it was a little harder though.