Skip to content

fixes 3d thumbnail clone when no xaxis in scene #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2017
Merged

fixes 3d thumbnail clone when no xaxis in scene #1327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/snapshot/cloneplot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,26 @@ module.exports = function clonePlot(graphObj, options) {
};
}
for(i = 0; i < sceneIds.length; i++) {
var sceneId = sceneIds[i];
var scene = newLayout[sceneIds[i]];

extendFlat(newLayout[sceneId].xaxis, axesImageOverride);
extendFlat(newLayout[sceneId].yaxis, axesImageOverride);
extendFlat(newLayout[sceneId].zaxis, axesImageOverride);
if(!scene.xaxis) {
scene.xaxis = {};
}

if(!scene.yaxis) {
scene.yaxis = {};
}

if(!scene.zaxis) {
scene.zaxis = {};
}

extendFlat(scene.xaxis, axesImageOverride);
extendFlat(scene.yaxis, axesImageOverride);
extendFlat(scene.zaxis, axesImageOverride);

// TODO what does this do?
newLayout[sceneId]._scene = null;
scene._scene = null;
}
}

Expand Down
36 changes: 36 additions & 0 deletions test/jasmine/tests/snapshot_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,42 @@ describe('Plotly.Snapshot', function() {
expect(thumbTile.layout.annotations).toEqual(THUMBNAIL_DEFAULT_LAYOUT.annotations);
});

it('should create a 3D thumbnail with limited attributes', function() {

var figure = {
data: [{
type: 'scatter',
mode: 'markers',
y: [2, 4, 6, 5, 7, 4],
x: [1, 3, 4, 6, 3, 1],
name: 'C'
}],
layout: {
autosize: true,
scene: {
aspectratio: {y: 1, x: 1, z: 1}
}
}};


var thumbnailOptions = {
tileClass: 'thumbnail'
};

var AXIS_OVERRIDE = {
title: '',
showaxeslabels: false,
showticklabels: false,
linetickenable: false
};

var thumbTile = Plotly.Snapshot.clone(figure, thumbnailOptions);
expect(thumbTile.layout.scene.xaxis).toEqual(AXIS_OVERRIDE);
expect(thumbTile.layout.scene.yaxis).toEqual(AXIS_OVERRIDE);
expect(thumbTile.layout.scene.zaxis).toEqual(AXIS_OVERRIDE);
});


it('should create a custom sized Tile based on options', function() {
var customOptions = {
tileClass: 'notarealclass',
Expand Down