Skip to content

3d zeroline modification #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 16, 2015
Merged

3d zeroline modification #112

merged 6 commits into from
Dec 16, 2015

Conversation

cldougl
Copy link
Member

@cldougl cldougl commented Dec 14, 2015

  • remove dataCenter var so zeroline shows at 0 for scatter3d and surface plots

@cldougl
Copy link
Member Author

cldougl commented Dec 15, 2015

still broken for log axes where the zeroline is shown at 1 i.e.

etpinard
etpinard reviewed Dec 16, 2015
View reviewed changes
src/plots/gl3d/layout/convert.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@etpinard
Copy link
Contributor

@cldougl Great job. 3D 🐛 s are the hardest to slay.

💃

cldougl added a commit that referenced this pull request Dec 16, 2015
@cldougl
Merge pull request #112 from plotly/3d_zeroline_bug
7992cb9 
3d zeroline modification
@cldougl cldougl merged commit 7992cb9 into master Dec 16, 2015
@cldougl cldougl mentioned this pull request Dec 16, 2015
Closed
@etpinard etpinard deleted the 3d_zeroline_bug branch December 16, 2015 15:04
@etpinard etpinard mentioned this pull request Jun 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cldougl @etpinard