Skip to content

Upgrade to Swift 5 #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2019
Merged

Upgrade to Swift 5 #158

merged 4 commits into from
Mar 27, 2019

Conversation

jessesquires
Copy link
Contributor

@jessesquires jessesquires commented Mar 25, 2019 •
edited
Loading

  • Upgrade to Xcode 10
  • Migrate to Swift 5
  • Run pod install
  • Upgrade DifferenceKit
  • Bump version numbers
  • Update changelog
  • Re-gen docs

@jessesquires
Copy link
Contributor Author

We are currently blocked by ra1028/DifferenceKit#55

@jessesquires jessesquires added this to the 0.5.0 milestone Mar 25, 2019
@PlanBot-iOS
Copy link

PlanBot-iOS commented Mar 25, 2019 •
edited
Loading

1 Error
🚫 Docs are regenerated when creating new releases.
1 Warning
⚠️ Big PR
1 Message
📖 Docs are generated by using Jazzy. If you want to contribute, please update the markdown guides or doc comments.

Generated by 🚫 Danger

asmallteapot
asmallteapot reviewed Mar 25, 2019
View reviewed changes
@jessesquires
Copy link
Contributor Author

sweet. differencekit just merged that and release 1.1.0

updating

@jessesquires
Copy link
Contributor Author

travis is going to fail because it doesn't have xcode10.2 yet

shocking

@jessesquires jessesquires merged commit 40fe60a into master Mar 27, 2019
@jessesquires jessesquires deleted the jsq/swift-5 branch March 27, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@asmallteapot asmallteapot asmallteapot left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jessesquires @PlanBot-iOS @asmallteapot