Organize imports and fix "e" bug #424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused variable
asset_report_pdf
.Removed unused imports:
Simplified import and usage of
datetime
functions.Fixed a bug in
while num_retries_remaining > 0
code block, and the line just following it. In both theerror_response = ...
andif asset_report_json ...
blocks, the variablee
was unbound. This is resolved by declaringerr
as None before the block, then assigning toerr
on each retry.err
is then used after thewhile
block.I also put an
else:
before the two lines starting witherror_response = ...
so they would actually run. My assumption is that these were meant to run if the error is anything aside fromPRODUCT_NOT_READY
, whereas currently thecontinue
statement makes those lines unreachable.