Avoid using OpenStruct where Struct is enough #1037
Conversation
|
@amatsuda Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
@pivotal-cla This is an Obvious Fix |
|
@amatsuda This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
this fixes a NameError on recent versions of Ruby that requires to explicitly bundle ostruct gem e.g. https://norsk.cf-app.com/builds/446820782
|
Ruby 2.6 CI fails https://norsk.cf-app.com/builds/446825268 due to ba4910e. |
|
@amatsuda Thanks for the PR. I saw this after but added the fix by explicitly requiring openstruct |
|
@xtreme-shane-lattanzio No problem, I'm totally fine with that. But maybe I should have wrote in the PR description that use of ostruct is now mildly warned due to performance reason ruby/ostruct#56 |
On PR #1036, I saw a CI failure that is unrelated to its changeset.
https://norsk.cf-app.com/builds/446820782
The error
NameError: uninitialized constant LicenseFinder::OpenStructimplies that we should explicitly bundle "ostruct" gem, but in this case I'd suggest to simply use Struct instead of OpenStruct.