Fallback for Web Audio on Firefox #7083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to merge this but please change the branch to master. |
raaaahman
force-pushed
the
fix/web-audio-firefox-safari
branch
from
3b190bc to
08ee5b5
Compare
|
Alright, done. |
|
Hi @raaaahman. Thanks for the PR. We have merged it with the |
|
I deployed a game with the fix: https://phaser-webaudio-test.pages.dev/, it works on my browser (Mozilla Firefox snap for Ubuntu 136.0.3). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Describe the changes below:
Firefox doesn't implement the
positionX,positionYandpositionZproperties on theAudioListenerinstances at the moment. This prevents the follow feature fromWebAudioSoundto operate on Firefox. This PR aims to solve that issue.