docs: hooks terminology update #13847
Open
+22
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're not wrong, it is a bit misleading and I've updated the verbiage accordingly and provided examples
AlessioGr
reviewed
Sep 17, 2025
docs/hooks/overview.mdx
Outdated
| ```ts | ||
| const afterChange = ({ doc }) => { | ||
| // Trigger side-effect without blocking | ||
| pingAnalyticsService(doc.id) |
There was a problem hiding this comment.
We can use the void keyword to signalize that this is a floating promise (unawaited async function call). By default, typescript-eslint will throw a warning if this is not set:
void pingAnalyticsService(doc.id)There was a problem hiding this comment.
finally got around to making this small change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #10460 It is a bit misleading the way it is worded currently—so I've updated the verbiage accordingly and provided code snippets