Add strict=True to all test file list comprehensions #62625
Draft
+419
−412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was one with some iteration using `ruff check --fix` and cursor. Started with tests, since those shouldn't require a close review. NOTE: I am actually hoping for test failures, so we can work as a group to polish the PR over the finish line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one with some iteration using
ruff check --fixand cursor. Started with tests, since those shouldn't require a close review.This may have been a bad idea, but we discussed how to approach it and the question came up if we can't automate it together with @floura-angel, @saakshimore, and @Tsmith-77.
The discussion continued a bit that one way to work together on something is to split it up, but another way is to actually collaborate directly on a PR.
In this case, this would mean if tests fail (I am hoping almost), you can add my fork and pull/push to my branch directly. (
gh checkout prmay work also if you use the github interface.)Towards gh-62434
I am happy to not pursue this if this idea of automation and collaborating on a PR turns out too unwieldy or just not great.