API: series int-slicing always positional #49869
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Nov 24, 2022
| assert (ser[:4] == 0).all() | ||
| with tm.assert_produces_warning(FutureWarning, match=msg): | ||
| assert not (ser[4:] == 0).any() | ||
| ser[:4] = 0 |
There was a problem hiding this comment.
I might misunderstand this, but as I see it this would pass if both (getitem and setitem) are label based? If yes, can you set explicitly to 0 during creation?
Edit: Sorry missed the test name. Rather using iloc to get the values then?
mroeschke
added
the
Indexing
phofl
reviewed
Dec 2, 2022
|
One more merge conflict otherwise good to merge |
|
Another conflict but feel free to merge when fixed |
|
Discussed on the dev call yesterday, decided to just revert the deprecation in 1.5.3. closing. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.