CLN: consistently put '|' at start of line in pygrep hooks #39301 #39304
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Jan 20, 2021
|
thanks @gcmaciel prob need a precommit meta-hook here (heheh) |
nofarm3
pushed a commit
to nofarm3/pandas
that referenced
this pull request
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
|at start of line in pygrep hooks #39301I moved the
|symbols from the end of the line to the beginning of the line in pygrep hooks.I also added the
|symbol in thenon-standard-imports-in-testsat the beginning of the line 93, which was missing as @MarcoGorelli pointed.