Skip to content

try to fix an exception on Mac (second try) #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2023
Merged

try to fix an exception on Mac (second try) #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Source/OxyPlot.Xamarin.Forms.Platform.MacOS/PlotViewRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ protected override void OnElementChanged(ElementChangedEventArgs<Xamarin.Forms.P
return;
}

this.DetachModelFromView();

var plotView = new PlotView
{
Model = this.Element.Model,
Expand All @@ -78,6 +80,7 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE

if (e.PropertyName == Xamarin.Forms.PlotView.ModelProperty.PropertyName)
{
this.DetachModelFromView();
this.Control.Model = this.Element.Model;
}

Expand All @@ -95,5 +98,14 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE
this.Control.InvalidatePlot (false);
}
}

void DetachModelFromView()
{
var model = base.Element.Model as OxyPlot.IPlotModel;
if (model != null)
{
model.AttachPlotView(null);
}
}
}
}