Skip to content

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Dec 5, 2023

Summary

  • As a developer, I want to avoid non-deterministic return values in optimizely_get_config method so that I can anticipate the return values in my application logic.
  • The problem: we have flag 1 and flag 2. We have experiment rule A with id 123 and experiment rule A with id 456 (same rule key). Flag 1 has the first experiment rule A, flag 2 has the second experiment rule A. Has a rule with the same experiment key.
    We want to avoid that, so we provide a check and a warning log.

Test plan

  • write unit tests

Issues

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mat001 Mat001 merged commit f778989 into master Dec 6, 2023
@Mat001 Mat001 deleted the mpirnovar-duplicate-exper-key branch December 6, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants