Skip to content

fix: reducing log level of failure to patch in handleErrorStatusHandler #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reducing log level of failure to patch in handleErrorStatusHandler #2983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions .../src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
package io.javaoperatorsdk.operator.processing.event;

import java.lang.reflect.InvocationTargetException;
import java.net.HttpURLConnection;
import java.util.function.Function;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.slf4j.event.Level;

import io.fabric8.kubernetes.api.model.HasMetadata;
import io.fabric8.kubernetes.api.model.KubernetesResourceList;
Expand Down Expand Up @@ -216,12 +218,35 @@ public boolean isLastAttempt() {
customResourceFacade.patchStatus(
errorStatusUpdateControl.getResource().orElseThrow(), originalResource);
} catch (Exception ex) {
log.error(
"updateErrorStatus failed for resource: {} with version: {} for error {}",
getUID(resource),
getVersion(resource),
e.getMessage(),
ex);
int code = ex instanceof KubernetesClientException kcex ? kcex.getCode() : -1;
Level exceptionLevel = Level.ERROR;
String failedMessage = "";
if (context.isNextReconciliationImminent()
|| !(errorStatusUpdateControl.isNoRetry() || retryInfo.isLastAttempt())) {
if (code == HttpURLConnection.HTTP_CONFLICT
|| (originalResource.getMetadata().getResourceVersion() != null && code == 422)) {
exceptionLevel = Level.DEBUG;
failedMessage = " due to conflict";
log.info(
"ErrorStatusUpdateControl.patchStatus of {} failed due to a conflict, but the next"
+ " reconiliation is imminent.",
ResourceID.fromResource(originalResource));
} else {
exceptionLevel = Level.WARN;
failedMessage = ", but will be retried soon,";
}
}

log.atLevel(exceptionLevel)
.log(
"ErrorStatusUpdateControl.patchStatus failed{} for {} with UID: {} and version: {}"
+ " for error {}",
failedMessage,
ResourceID.fromResource(originalResource),
getUID(resource),
getVersion(resource),
e.getMessage(),
ex);
}
}
if (errorStatusUpdateControl.isNoRetry()) {
Expand Down