[NPU] Move serialize functions to ir_serializer #32241
Open
+436
−434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexandruenache1111 <[email protected]>
pereanub
reviewed
Sep 29, 2025
| * before copying. | ||
| * @details This is meant as a replacement for the legacy "ie_memcpy" function coming from the OpenVINO API. | ||
| */ | ||
| void checkedMemcpy(void* destination, size_t destinationSize, const void* source, size_t numberOfBytes); |
There was a problem hiding this comment.
why is this part of the header as well?
| #include "custom_stream_buffer.hpp" | ||
| #include "intel_npu/utils/logger/logger.hpp" | ||
| #include "openvino/pass/manager.hpp" | ||
| #include "ze_graph_ext_wrappers.hpp" |
There was a problem hiding this comment.
Is this really needed here?
| * API, the layout fields shall be filled with default values in order to assure the backward compatibility | ||
| * with the driver. | ||
| */ | ||
| SerializedIR serializeIR(const std::shared_ptr<const ov::Model>& model, |
There was a problem hiding this comment.
why is this a global function and not part of the IRSerializer?
| * @brief For driver backward compatibility reasons, the given value shall be converted to a string corresponding to the | ||
| * adequate legacy precision. | ||
| */ | ||
| std::string ovPrecisionToLegacyPrecisionString(const ov::element::Type& precision); |
There was a problem hiding this comment.
why is this needed in the .hpp?
| * the default one may lead either to error or to accuracy failures since unwanted transposition layers may be | ||
| * introduced. | ||
| */ | ||
| std::string rankToLegacyLayoutString(const size_t rank); |
| */ | ||
| std::string rankToLegacyLayoutString(const size_t rank); | ||
|
|
||
| std::string serializeIOInfo(const std::shared_ptr<const ov::Model>& model, const bool useIndices); |
There was a problem hiding this comment.
why isn't this part of the IRSerializer class?
|
|
||
| std::string serializeIOInfo(const std::shared_ptr<const ov::Model>& model, const bool useIndices); | ||
|
|
||
| std::string serializeConfig(const Config& config, |
XinWangIntel
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
LGTM, we use dedicated function to support flex version control in driver compiler adapter before. Since #32121 removed support for some old ext versions, refactor also work for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
serializeIR,serializeIOInfo,serializeConfig,checkedMemcpy,ovPrecisionToLegacyPrecisionString, andrankToLegacyLayoutStringfromdriver_compiler_adaptertoir_serializer.Tickets: