Skip to content

Conversation

sgbihu
Copy link
Contributor

@sgbihu sgbihu commented Sep 26, 2025

Details:

  • Add a stable parameter to make the CPU use a stable algorithm.

Tickets:

@sgbihu sgbihu requested a review from a team as a code owner September 26, 2025 05:55
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Sep 26, 2025
@mvafin mvafin self-assigned this Sep 26, 2025
@sgbihu sgbihu requested a review from mvafin September 26, 2025 11:18
@sgbihu
Copy link
Contributor Author

sgbihu commented Sep 29, 2025

build_jenkins

m_select_last_index{node.get_attribute_value<std::int64_t>("select_last_index", 0)} {}

std::shared_ptr<ov::Node> ArgMinMaxFactory::make_arg_max() const {
ov::OutputVector ArgMinMaxFactory::make_arg_max() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense for this to return ov::Output<ov::Node> instead of vector.

Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have test for this behavior?

@sgbihu sgbihu requested a review from mvafin September 29, 2025 22:58
@sgbihu
Copy link
Contributor Author

sgbihu commented Sep 29, 2025

Can we have test for this behavior?

I have modified the existing test to cover this.

@mvafin mvafin enabled auto-merge September 30, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants