Skip to content

Conversation

isanghao
Copy link
Contributor

@isanghao isanghao commented Aug 12, 2025

When chat-template is enabled, CI failed with the error message below:

..\..\tmp\llm_accuracy_venv\lib\site-packages\transformers\utils\chat_template_utils.py:458: in render_jinja_template
    compiled_template = _compile_jinja_template(chat_template)
..\..\tmp\llm_accuracy_venv\lib\site-packages\transformers\utils\chat_template_utils.py:418: in _compile_jinja_template
    raise ImportError(
E   ImportError: apply_chat_template requires jinja2>=3.1.0 to be installed. Your version is 3.0.1.

@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 05:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the jinja2>=3.1.0 dependency to requirements files for tools that likely use chat templates, which require Jinja2 for template rendering functionality.

  • Adds jinja2 dependency with minimum version constraint to two tool requirements files
  • Ensures consistent dependency specification across both affected tools

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/who_what_benchmark/requirements.txt Adds jinja2>=3.1.0 dependency for chat template support
tools/llm_bench/requirements.txt Adds jinja2>=3.1.0 dependency for chat template support

@github-actions github-actions bot added category: llm_bench Label for tool/llm_bench folder category: WWB PR changes WWB labels Aug 12, 2025
@Wovchena Wovchena requested a review from sbalandi August 12, 2025 05:36
@MaximProshin
Copy link
Collaborator

@yatarkan , @Wovchena , as we switched to Minja in GenAI do we still have a need for jinja dependency?

@Wovchena
Copy link
Collaborator

Yes because the PR isn't about GenAI but wwb

@MaximProshin
Copy link
Collaborator

Yes because the PR isn't about GenAI but wwb

Why can't we also remove it from WWB?

@Wovchena
Copy link
Collaborator

WWB uses transformers which uses jinja2

@sbalandi sbalandi added this pull request to the merge queue Aug 12, 2025
Merged via the queue into openvinotoolkit:master with commit 135cb20 Aug 12, 2025
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: llm_bench Label for tool/llm_bench folder category: WWB PR changes WWB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants