Set encoding #2564
Merged
Set encoding #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| prompts_file_path = LONG_PROMPTS_FILE if self.long_prompt else PROMPTS_FILE | ||
| data_path = files('whowhatbench.prompts').joinpath(prompts_file_path) | ||
| prompt_data = yaml.safe_load(data_path.read_text()) | ||
| prompt_data = yaml.safe_load(data_path.read_text(encoding='utf-8')) |
There was a problem hiding this comment.
While adding explicit encoding is good practice, consider using 'utf-8-sig' encoding instead of 'utf-8' to handle files that may contain a UTF-8 BOM (Byte Order Mark), which is common in Windows environments and could cause YAML parsing issues.
Suggested change
| prompt_data = yaml.safe_load(data_path.read_text(encoding='utf-8')) | |
| prompt_data = yaml.safe_load(data_path.read_text(encoding='utf-8-sig')) |
Copilot uses AI. Check for mistakes.
Ticket 171890. No Idea if it helps
sbalandi
approved these changes
Aug 8, 2025
|
Can you copy wwb tests to run them on Windows and mac |
yes, I will add tests for win/mac |
Merged
via the queue into
openvinotoolkit:master
with commit Aug 8, 2025
373c001
110 of 114 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket 171890. No Idea if it helps