image_generation: fix argument order #2462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects argument order issues detected by Coverity static analysis. The main purpose is to fix the parameter order when calling check_image_size() across multiple image generation pipeline classes, swapping width and height arguments to match the expected function signature.
- Fixed argument order in
check_image_size()calls across 5 image generation pipeline classes - Refactored
create_streamer()function to directly return the result instead of using an intermediate variable
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/cpp/src/utils.cpp | Simplified return logic in create_streamer() function |
| src/cpp/src/image_generation/stable_diffusion_xl_pipeline.hpp | Fixed argument order in check_image_size() call |
| src/cpp/src/image_generation/stable_diffusion_pipeline.hpp | Fixed argument order in check_image_size() call |
| src/cpp/src/image_generation/stable_diffusion_3_pipeline.hpp | Fixed argument order in check_image_size() call |
| src/cpp/src/image_generation/flux_pipeline.hpp | Fixed argument order in check_image_size() call |
| src/cpp/src/image_generation/flux_fill_pipeline.hpp | Fixed argument order in check_image_size() call |
github-actions
bot
added
category: image generation
Detected by Coverity
likholat
approved these changes
Jul 21, 2025
Merged
via the queue into
openvinotoolkit:master
with commit Jul 25, 2025
7d3d6c7
99 of 101 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected by Coverity