Support to collect latency for transformers V4.52.0 #2373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgzintel
changed the title
wgzintel
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for latency collection when using transformers v4.52.0 along with reorganizing hook sample and beam search files into dedicated directories. Key changes include replacing the hook sample implementation for v4.52.0, updating beam search logic for both v4.52.0 and v4.51.0 variants, and modifying the import paths in the greedy search hook.
Reviewed Changes
Copilot reviewed 4 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/llm_bench/llm_bench_utils/llm_hook_sample/hook_sample_v52.py | New sample-generation implementation for transformers v4.52.0 with latency collection |
| tools/llm_bench/llm_bench_utils/llm_hook_beam_search/hook_beam_search_v52.py | New beam search implementation for transformers v4.52.0 with latency collection |
| tools/llm_bench/llm_bench_utils/llm_hook_beam_search/hook_beam_search_v51.py | Retained beam search implementation for transformers v4.51.0 with latency collection |
| tools/llm_bench/llm_bench_utils/hook_greedy_search.py | Updated import paths and version checks to use the appropriate hook sample module |
tools/llm_bench/llm_bench_utils/llm_hook_beam_search/hook_beam_search_v52.py
Outdated
Show resolved
Hide resolved
…_search_v52.py Co-authored-by: Copilot <[email protected]>
sbalandi
approved these changes
Jun 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.