-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8167268: StandardGlyphVector.getGlyphMetrics creates metrics with erroneous bounds for characters with no outline (e.g., the space character ' ') #27580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gredler
wants to merge
2
commits into
openjdk:master
Choose a base branch
from
gredler:JDK-8167268
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−6
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
/* | ||
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/* | ||
* @test | ||
* @bug 8167268 | ||
* @summary Checks behavior of GlyphVector.getGlyphMetrics(int). | ||
*/ | ||
|
||
import java.awt.Font; | ||
import java.awt.Rectangle; | ||
import java.awt.font.FontRenderContext; | ||
import java.awt.font.GlyphMetrics; | ||
import java.awt.font.GlyphVector; | ||
import java.awt.font.TextLayout; | ||
import java.awt.geom.Rectangle2D; | ||
|
||
public class GlyphMetricsTest { | ||
|
||
public static void main(String[] args) { | ||
|
||
String text = "The quick brown \r\n fox JUMPS over \t the lazy dog."; | ||
Font font = new Font(Font.DIALOG, Font.PLAIN, 60); | ||
FontRenderContext frc = new FontRenderContext(null, true, true); | ||
GlyphVector gv = font.createGlyphVector(frc, text); | ||
|
||
for (int i = 0; i < gv.getNumGlyphs(); i++) { | ||
|
||
GlyphMetrics gm = gv.getGlyphMetrics(i); | ||
Rectangle2D bounds = gm.getBounds2D(); | ||
assertEqual(gm.getAdvance(), gm.getAdvanceX(), 0, "advance x", i); | ||
assertEqual(0, gm.getAdvanceY(), 0, "advance y", i); | ||
|
||
// assumes one glyph per char in the test text | ||
String character = text.substring(i, i + 1); | ||
TextLayout layout = new TextLayout(character, font, frc); | ||
Rectangle pixelBounds = layout.getPixelBounds(frc, 0, 0); | ||
assertEqual(pixelBounds.getWidth(), bounds.getWidth(), 2, "width", i); | ||
assertEqual(pixelBounds.getHeight(), bounds.getHeight(), 2, "height", i); | ||
assertEqual(pixelBounds.getX(), bounds.getX(), 2, "x", i); | ||
assertEqual(pixelBounds.getY(), bounds.getY(), 2, "y", i); | ||
} | ||
} | ||
|
||
private static void assertEqual(double d1, double d2, double variance, | ||
String scenario, int index) { | ||
if (Math.abs(d1 - d2) > variance) { | ||
String msg = String.format("%s for index %d: %f != %f", scenario, index, d1, d2); | ||
throw new RuntimeException(msg); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double check: do we want to skip glyphs only when the bounds are empty, or we also want to skip them when the bounds are flipped (negative width/height)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know when that might happen? This code gets its values (after a few layers of abstraction) from
StandardGlyphVector$GlyphStrike.getGlyphOutlineBounds(int, float, float)
, which has a similarisEmpty
check.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if it is possible, but I would like to make sure we did not introduce any issues, since isEmpty() will skip ‘flipped’ bounds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main thing is that the condition which adds the "aggregate" position to the glyph bounds is the same condition which later undoes this and converts the position back to the "single glyph" position. The code which adds the total advance the glyph position uses
isEmpty
, so I think the code which undoes it (the code being added in this PR) needs to use it as well:jdk/src/java.desktop/share/classes/sun/font/StandardGlyphVector.java
Line 1798 in 76dba20