small refactor #1249
Merged
small refactor #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hqhq
reviewed
Jan 4, 2017
| func FindCgroupMountpoint(subsystem string) (string, error) { | ||
| // We are not using mount.GetMounts() because it's super-inefficient, | ||
| // parsing it directly sped up x10 times because of not using Sscanf. | ||
| // It was one of two major performance drawbacks in container start. |
There was a problem hiding this comment.
OK, I move it in func FindCgroupMountpointAndRoot
Signed-off-by: Wang Long <[email protected]>
datawolf
force-pushed
the
small-refactor
branch
from
45223f9 to
4732f46
Compare
|
ping @hqhq |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wang Long [email protected]